optional active and dormant buying periods in Storage #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearkatie
force-pushed
the
source_dormant_period
branch
from
36369d7 to
d0644c7
Compare
gonuke
requested changes
Nov 28, 2023
|
I'm not sure how the random sink stuff ended up in this PR? Did you merge it in? We might need to roll that back somehow? |
Co-authored-by: Paul Wilson <[email protected]>
Co-authored-by: Paul Wilson <[email protected]>
nuclearkatie
force-pushed
the
source_dormant_period
branch
from
74b3b29 to
121de18
Compare
Looks like you saw this at about the same time I did... ignore |
gonuke
approved these changes
Nov 28, 2023
|
All current tests are passing - not sure why CircleCI is running - will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the active and dormant buy policy periods (relies on Cyclus PR #1596) in Storage
Don't merge until the underlying Cyclus PR is merged (tests won't pass until then, anyway)